Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: add schema name, table name to ddl job. (#11561) (#15450) #16428

Merged
merged 3 commits into from
Apr 15, 2020
Merged

model: add schema name, table name to ddl job. (#11561) (#15450) #16428

merged 3 commits into from
Apr 15, 2020
+97 −9

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 15, 2020

cherry-pick #15450 to release-3.0

What problem does this PR solve?

cherry-pick #11561

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 15, 2020
Merged
@sre-bot sre-bot requested review from bb7133 and zimulala April 15, 2020 12:34
@XuHuaiyu XuHuaiyu mentioned this pull request Apr 15, 2020
Merged
zimulala
zimulala reviewed Apr 15, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2020
djshow832
djshow832 approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 16431, 16429

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit ee09632 into pingcap:release-3.0 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@djshow832 djshow832 djshow832 approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

@crazycs520 crazycs520

Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @zimulala @djshow832 @zz-jason @XuHuaiyu @crazycs520